On Fri, Aug 10, 2012 at 5:48 PM, Michal Hocko <mho...@suse.cz> wrote: > On Fri 03-08-12 15:32:35, Michal Hocko wrote: >> On Fri 03-08-12 20:56:45, Hillf Danton wrote: >> > The computation of page offset index is open coded, and incorrect, to >> > be used in scanning prio tree, as huge page offset is required, and is >> > fixed with the well defined routine. >> >> I guess that nobody reported this because if someone really wants to >> share he will use aligned address for mmap/shmat and so the index is 0. >> Anyway it is worth fixing. Thanks for pointing out! > > I have looked at the code again and I don't think there is any problem > at all. vma_prio_tree_foreach understands page units so it will find > appropriate svmas. > Or am I missing something?
Well, what if another case of vma_prio_tree_foreach used by hugetlb is correct? Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
