On Mon, Aug 20, 2012 at 2:41 PM, Marina Makienko <[email protected]> wrote: > Code inspection shows that this can > only be triggered by calling napi_enable() without > napi_disable(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Marina Makienko <[email protected]> > --- > drivers/staging/octeon/ethernet-rx.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-rx.c > b/drivers/staging/octeon/ethernet-rx.c > index 34afc16..db81613 100644 > --- a/drivers/staging/octeon/ethernet-rx.c > +++ b/drivers/staging/octeon/ethernet-rx.c > @@ -560,4 +560,5 @@ void cvm_oct_rx_shutdown(void) > /* Shutdown all of the NAPIs */ > for_each_possible_cpu(i) > netif_napi_del(&cvm_oct_napi[i].napi); > + napi_disable(&cvm_oct_napi[i].napi); > }
Looks like napi_disable is meant to be inside for_each_possible_cpu loop, but curly braces are missing. -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
