On Thursday 30 August 2012 20:18:41 SeungGoo, Kim wrote:
> @@ -748,8 +752,9 @@ int usbnet_open (struct net_device *net)
> goto done_nopm;
> }
>
> - // put into "known safe" state
> - if (info->reset && (retval = info->reset (dev)) < 0) {
> + /* put into "known safe" state */
> + retval = info->reset(dev);
> + if (info->reset && retval < 0) {
> netif_info(dev, ifup, dev->net,
> "open reset fail (%d) usbnet usb-%s-%s, %s\n",
Dave,
please don't take this patch. It changes code and breaks the driver.
A great big NACK.
Kim,
please do not send coding style patches which change code.
As an exercise think about this piece of code.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
