A trivial memory leak fix while calling system_path Since v1: Remove an unnecessary null pointer check per Felipe's comments
Signed-off-by: Liang Xie <[email protected]> --- tools/perf/util/exec_cmd.c | 4 +++- tools/perf/util/help.c | 1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tools/perf/util/exec_cmd.c b/tools/perf/util/exec_cmd.c index 7adf4ad..d041407 100644 --- a/tools/perf/util/exec_cmd.c +++ b/tools/perf/util/exec_cmd.c @@ -83,8 +83,9 @@ void setup_path(void) { const char *old_path = getenv("PATH"); struct strbuf new_path = STRBUF_INIT; + const char *exec_path = perf_exec_path(); - add_path(&new_path, perf_exec_path()); + add_path(&new_path, exec_path); add_path(&new_path, argv0_path); if (old_path) @@ -95,6 +96,7 @@ void setup_path(void) setenv("PATH", new_path.buf, 1); strbuf_release(&new_path); + free((void *)exec_path); } static const char **prepare_perf_cmd(const char **argv) diff --git a/tools/perf/util/help.c b/tools/perf/util/help.c index 6f2975a..798f66d 100644 --- a/tools/perf/util/help.c +++ b/tools/perf/util/help.c @@ -187,6 +187,7 @@ void load_command_list(const char *prefix, uniq(other_cmds); } exclude_cmds(other_cmds, main_cmds); + free((void *)exec_path); } void list_commands(const char *title, struct cmdnames *main_cmds, -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
