From: Wei Yongjun <yongjun_...@trendmicro.com.cn> The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> --- drivers/block/swim3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index 89ddab1..25a522d 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c @@ -1090,13 +1090,14 @@ static const struct block_device_operations floppy_fops = { static void swim3_mb_event(struct macio_dev* mdev, int mb_state) { struct floppy_state *fs = macio_get_drvdata(mdev); - struct swim3 __iomem *sw = fs->swim3; + struct swim3 __iomem *sw; if (!fs) return; if (mb_state != MB_FD) return; + sw = fs->swim3; /* Clear state */ out_8(&sw->intr_enable, 0); in_8(&sw->intr); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
