On 09/18/2012 07:28 AM, Rob Herring wrote: > On 09/18/2012 03:51 AM, Thierry Reding wrote: >> In order to use GPIO controllers as interrupt controllers, they need to >> be marked with the DT interrupt-controller property. This commit adds >> some documentation about this to the general GPIO binding document. >> >> Cc: Linus Walleij <[email protected]> >> Cc: Grant Likely <[email protected]> >> Cc: Rob Herring <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> Signed-off-by: Thierry Reding <[email protected]> > > Applied for 3.7. > > Rob > >> --- >> Documentation/devicetree/bindings/gpio/gpio.txt | 33 >> +++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt >> b/Documentation/devicetree/bindings/gpio/gpio.txt >> index 4e16ba4..8d125b0 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt >> @@ -75,4 +75,37 @@ Example of two SOC GPIO banks defined as gpio-controller >> nodes: >> gpio-controller; >> }; >> >> +If the GPIO controller supports the generation of interrupts, it should >> +also contain an empty "interrupt-controller" property as well as an >> +"#interrupt-cells" property. This is required in order for other nodes >> +to use the GPIO controller as their interrupt parent.
Surely this is generic information for any interrupt controller, and hence doesn't belong in the GPIO binding? >> +If #interrupt-cells is 1, the single cell is used to specify the number >> +of the GPIO that is to be used as an interrupt. >> + >> +If #interrupt-cells is 2, the first cell is used to specify the number >> +of the GPIO that is to be used as an interrupt, whereas the second cell >> +is used to specify any of the following flags: >> + - bits[3:0] trigger type and level flags >> + 1 = low-to-high edge triggered >> + 2 = high-to-low edge triggered >> + 4 = active high level-sensitive >> + 8 = active low level-sensitive That certainly shouldn't be in the generic GPIO binding; the format of the interrupt specifier is determined by the binding for the individual device that is the interrupt controller. Just because a device is also a GPIO controller doesn't mean that it has to conform to a specific format for the interrupt specifier. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
