(2012/09/20 14:12), Hyeoncheol Lee wrote: > Before casting a type of a variable to string, > convert_variable_type() confirms that the type is a pointer or > an array. if it is a pointer to char, it is casted to string. > but in case of an array of char, it isn't
Oops, right! I missed the array case. This must be fixed. Acked-by: Masami Hiramatsu <[email protected]> Thank you! > > Cc: Masami Hiramatsu <[email protected]> > Cc: Srikar Dronamraju <[email protected]> > Signed-off-by: Hyeoncheol Lee <[email protected]> > --- > tools/perf/util/probe-finder.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 1daf5c1..be03293 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -413,12 +413,12 @@ static int convert_variable_type(Dwarf_Die *vr_die, > dwarf_diename(vr_die), dwarf_diename(&type)); > return -EINVAL; > } > + if (die_get_real_type(&type, &type) == NULL) { > + pr_warning("Failed to get a type" > + " information.\n"); > + return -ENOENT; > + } > if (ret == DW_TAG_pointer_type) { > - if (die_get_real_type(&type, &type) == NULL) { > - pr_warning("Failed to get a type" > - " information.\n"); > - return -ENOENT; > - } > while (*ref_ptr) > ref_ptr = &(*ref_ptr)->next; > /* Add new reference with offset +0 */ > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
