Re: [PATCHv2 3/4] dw_dmac: change {dev_}printk() to corresponding macros

[Felipe Balbi]

Hi,

On Wed, Oct 17, 2012 at 01:31:17PM +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> ---
>  drivers/dma/dw_dmac.c |   15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index c27c125..60b172a 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -456,9 +456,8 @@ static void dwc_scan_descriptors(struct dw_dma *dw, 
> struct dw_dma_chan *dwc)
>  
>  static inline void dwc_dump_lli(struct dw_dma_chan *dwc, struct dw_lli *lli)
>  {
> -     dev_printk(KERN_CRIT, chan2dev(&dwc->chan),
> -                     "  desc: s0x%x d0x%x l0x%x c0x%x:%x\n",
> -                     lli->sar, lli->dar, lli->llp, lli->ctlhi, lli->ctllo);
> +     dev_crit(chan2dev(&dwc->chan), "  desc: s0x%x d0x%x l0x%x c0x%x:%x\n",
> +              lli->sar, lli->dar, lli->llp, lli->ctlhi, lli->ctllo);

is this really critical ? To me it looks more like a debugging message.

>  }
>  
>  static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc)
> @@ -492,10 +491,8 @@ static void dwc_handle_error(struct dw_dma *dw, struct 
> dw_dma_chan *dwc)
>        * controller flagged an error instead of scribbling over
>        * random memory locations.
>        */
> -     dev_printk(KERN_CRIT, chan2dev(&dwc->chan),
> -                     "Bad descriptor submitted for DMA!\n");
> -     dev_printk(KERN_CRIT, chan2dev(&dwc->chan),
> -                     "  cookie: %d\n", bad_desc->txd.cookie);
> +     dev_crit(chan2dev(&dwc->chan), "Bad descriptor submitted for DMA!\n");
> +     dev_crit(chan2dev(&dwc->chan), "  cookie: %d\n", bad_desc->txd.cookie);

now this is critical, indeed. I would suggest using dev_WARN_ONCE() so
that it's noisy enough to catch the failing user.

>       dwc_dump_lli(dwc, &bad_desc->lli);
>       list_for_each_entry(child, &bad_desc->tx_list, desc_node)
>               dwc_dump_lli(dwc, &child->lli);
> @@ -1625,8 +1622,8 @@ static int __devinit dw_probe(struct platform_device 
> *pdev)
>  
>       dma_writel(dw, CFG, DW_CFG_DMA_EN);
>  
> -     printk(KERN_INFO "%s: DesignWare DMA Controller, %d channels\n",
> -                     dev_name(&pdev->dev), nr_channels);
> +     pr_info("%s: DesignWare DMA Controller, %d channels\n",
> +             dev_name(&pdev->dev), nr_channels);

you have a struct device available in platform_device, please use
dev_info() or dev_dbg().

>       dma_async_device_register(&dw->dma);
>  
> -- 
> 1.7.10.4
> 

-- 
balbi

signature.asc
Description: Digital signature