From: Sarah Nadi <sn...@uwaterloo.ca>

Based on v3.5-rc1, #ifdef check in arch/x86/kernel/apic/bigsmp_32.c is redundant as SMP will always be selected for the file to compile any ways (file compiles when X86_BIGSMP is selected, and X86_BIGSMP depends on SMP). The first block is always selected, and #else code block is therefore always dead. See patch below.

--- linux/arch/x86/kernel/apic/bigsmp_32.c.orig 2012-11-01 13:53:24.781158327 -0400 +++ linux/arch/x86/kernel/apic/bigsmp_32.c 2012-11-01 13:54:39.501438248 -0400
@@ -28,11 +28,7 @@ static int bigsmp_apic_id_registered(voi

 static const struct cpumask *bigsmp_target_cpus(void)
 {
-#ifdef CONFIG_SMP
     return cpu_online_mask;
-#else
-    return cpumask_of(0);
-#endif
 }

static unsigned long bigsmp_check_apicid_used(physid_mask_t *map, int apicid)


Signed-off-by: Sarah Nadi <sn...@uwaterloo.ca>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to