On Tue, Dec 18, 2012 at 05:14:57AM -0700, Andreas Dilger wrote: > On 2012-12-15, at 19:15, Dave Chinner <da...@fromorbit.com> wrote: > > > > On Sat, Dec 15, 2012 at 11:25:23PM +0800, ys wrote: > >> From 3d56c131b58a21c05bcd677b9d2ba915abcbf195 Mon Sep 17 00:00:00 2001 > >> From: yangsheng <sick...@gmail.com> > >> Date: Sat, 15 Dec 2012 21:46:22 +0800 > >> Subject: [PATCH] vfs: update atimes over one day in the past or future > >> > >> Relatime should update the inode atime if it is more than one day > >> in the future. The original problem seen was a tarball that had > >> a bad atime in the distant future, but could also happen if someone > >> fat-fingers a "touch". The future atime will never be fixed. > >> > >> Without relatime enabled, a future atime is updated to the current > >> kernel time on access. Relatime is meant to reduce the frequency > >> of atime updates, not decide if whether the system clock or the > >> inode timestamp is correct or not. > >> > >> Signed-off-by: Yang Sheng <sick...@gmail.com> > >> Signed-off-by: Andreas Dilger <adil...@dilger.ca> > >> Acked-by: David Chinner <da...@fromorbit.com> > > > > No I didn't. Please don't add tags that someone has not added > > directly in a reply to the original patch. > > That's my fault. I thought you'd OK'd the patch with the revised commit > comment.
Easy enough to misunderstand. :/ I simply avoid the issue by only adding tags that have been directly sent by people... > >> CC: sta...@vger.kernel.org > >> --- > >> fs/inode.c | 7 ++++--- > >> 1 ??????????????????????????? 4 ???(+)????????? 3 ???(-) > > > > There's something wrong with the character encoding you are using... > > Chinese locale, but probably doesn't matter since text below "---" isn't in > the commit anyway? Yup, but it doesn't inspire confidence that the patch is going to be clean when multiple encodings appear in the one message... > > Also, you've added an extra line of whitespace damage that doesn't > > need to be there..... > > > > FWIW, could you write a test for xfstests for this behaviour > > so we can confirm that we don't break it in future? > > Sure, I'll take a crack at that. Great. Thanks for the followup, Andreas. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
