Hi,
On Mon, Jan 07, 2013 at 07:11:58PM +0100, Laurent Pinchart wrote:
> > + l2index = (iova >> 12) & 0xff;
> > + spin_lock(&sh_domain->map_lock);
> > + ret = l2alloc(sh_domain, l1index);
>
> l2alloc calls dma_pool_alloc(GFP_KERNEL), that not safe in a non-sleepable
> context. Do we need a spinlock here, or could a mutex do ?
iommu_map should work in any context, so a mutex will not work. Also the
memory allocations in that path should be GFP_ATOMIC instead of
GFP_KERNEL.
Other than that this driver looks good from an IOMMU-API perspective.
Please Cc me on future versions of this patch-set directly.
Thanks,
Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
