> -----Original Message----- > From: Arnd Bergmann [mailto:[email protected]] > Sent: Friday, January 25, 2013 5:44 PM > To: [email protected] > Cc: [email protected]; Arnd Bergmann; J. Bruce Fields; > Myklebust, Trond; [email protected]; [email protected] > Subject: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf' > > When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the > 'buf' variable in svc_printk to become unused. > Marking it as __maybe_unused avoids a harmless gcc warning. > > Without this patch, building at91_dt_defconfig results in: > > net/sunrpc/svc.c: In function 'svc_printk': > net/sunrpc/svc.c:1051:7: warning: unused variable 'buf' [-Wunused-variable] > > Signed-off-by: Arnd Bergmann <[email protected]> > Cc: "J. Bruce Fields" <[email protected]> > Cc: Trond Myklebust <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > net/sunrpc/svc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index dbf12ac..b1f5223 > 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -1047,7 +1047,7 @@ void svc_printk(struct svc_rqst *rqstp, const char > *fmt, ...) { > struct va_format vaf; > va_list args; > - char buf[RPC_MAX_ADDRBUFLEN]; > + char buf[RPC_MAX_ADDRBUFLEN] __maybe_unused; > > va_start(args, fmt);
Alternatively, just declare it using the RPC_IFDEBUG() macro. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
