Hi Felipe, Felipe Balbi <ba...@ti.com> wrote @ Fri, 8 Feb 2013 08:47:20 +0100:
> > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC) > > how about using: > > #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC) > > instead ? Why is IS_BUILTIN() prefered? > > -void tegra20_hotplug_init(void); > > -void tegra30_hotplug_init(void); > > +void tegra20_hotplug_shutdown(void); > > +void tegra30_hotplug_shutdown(void); > > aren't these two called only by tegra_hotplug_init() now ? Yes > That means they don't need to be exposed. tegra{20,30}_hotplug_shutdown are defined in sleep-tegra{20,30}.S and used in hotplug.c So I think that the above are necessary here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/