Re: [PATCH, RFC 1/8] ARM: localtimer: return percpu clkevt on register

[Felipe Balbi]

Hi,

On Mon, Feb 18, 2013 at 05:06:39PM +0530, Afzal Mohammed wrote:
> @@ -315,6 +315,7 @@ static struct local_timer_ops twd_lt_ops __cpuinitdata = {
>  static int __init twd_local_timer_common_register(struct device_node *np)
>  {
>       int err;
> +     struct clock_event_device *evt;
>  
>       twd_evt = alloc_percpu(struct clock_event_device *);
>       if (!twd_evt) {
> @@ -328,8 +329,8 @@ static int __init twd_local_timer_common_register(struct 
> device_node *np)
>               goto out_free;
>       }
>  
> -     err = local_timer_register(&twd_lt_ops);
> -     if (err)
> +     evt = local_timer_register(&twd_lt_ops);
> +     if (IS_ERR(evt))
>               goto out_irq;

this is wrong. Will return 0 even in the error case. Correct version
would be:

if (IS_ERR(evt)) {
        err = PTR_ERR(evt);
        goto out_irq;
}

-- 
balbi

signature.asc
Description: Digital signature