Em Thu, 21 Feb 2013 16:53:37 +0100 Borislav Petkov <[email protected]> escreveu:
> On Thu, Feb 21, 2013 at 12:38:59PM -0300, Mauro Carvalho Chehab wrote: > > That allows APEI GHES driver to report errors directly, using > > the EDAC error report API. > > > > Signed-off-by: Mauro Carvalho Chehab <[email protected]> > > --- > > drivers/edac/edac_core.h | 17 ++++++++ > > drivers/edac/edac_mc.c | 109 > > ++++++++++++++++++++++++++++++++++++----------- > > 2 files changed, 100 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/edac/edac_core.h b/drivers/edac/edac_core.h > > index 23bb99f..9c5da11 100644 > > --- a/drivers/edac/edac_core.h > > +++ b/drivers/edac/edac_core.h > > @@ -453,6 +453,23 @@ extern struct mem_ctl_info *find_mci_by_dev(struct > > device *dev); > > extern struct mem_ctl_info *edac_mc_del_mc(struct device *dev); > > extern int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, > > unsigned long page); > > + > > +void edac_raw_mc_handle_error(const enum hw_event_mc_err_type type, > > + struct mem_ctl_info *mci, > > + long grain, > > + const u16 error_count, > > + const int top_layer, > > + const int mid_layer, > > + const int low_layer, > > + const unsigned long page_frame_number, > > + const unsigned long offset_in_page, > > + const unsigned long syndrome, > > + const char *msg, > > + const char *location, > > + const char *label, > > + const char *other_detail, > > + const bool enable_per_layer_report); > > Why not merge this patch with 10/12? > > You're adding edac_raw_mc_handle_error here and rewriting it in 10/12. > This looks like unnecessary churn to me. I did this way to to follow the "one patch per logical change rule". The rationale for this patch is to allow doing raw error reports, as needed by changeset 06/12. The rationale for 10/12 was to reduce the stack pressure. While 10/12 touches on the above routine, it's main focus is to fix a previous fixup of using a large space inside the stack during the memory report preparation. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
