On Fri, Feb 22, 2013 at 05:20:56PM +0800, Dong Aisheng wrote: > On Fri, Feb 22, 2013 at 09:52:12AM +0100, Thierry Reding wrote: > > On Fri, Feb 22, 2013 at 04:29:55PM +0800, Dong Aisheng wrote: > > > On Fri, Feb 22, 2013 at 08:27:19AM +0100, Thierry Reding wrote: > > > ... > > > > > > > Otherwise, i'm also ok with this patch. > > > > > > > Acked-by: Dong Aisheng <dong.aish...@linaro.org> > > > > > > > > > > > > > > BTW, i did not see Samuel's tree having this new API. > > > > > > > So, who will pick this patch? > > > > > > > > > > > > I have same question. > > > > > > > > > > I CCed Thierry and Greg who may know it. > > > > > > > > Yes, devm_ioremap_resource() never returns NULL. You always need to > > > > check the returned pointer with IS_ERR(). The value that you return > > > > should be extracted from the pointer with PTR_ERR(). > > > > > > Thanks Thierry. > > > Since Samuel's mdf tree does not have your patch introducing > > > the new API of devm_ioremap_resource, > > > do you know which tree this patch can go through, Greg's driver core tree? > > > > I don't think it matters much at this point because Linus merged the > > driver core tree yesterday, so anything that gets applied now should > > automatically have the new API available. > > > I just tried update to latest linus tree, still did not find this API defined > in include/linux/io.h. > Would you mind point it out for me?
Commit 75096579c3ac39ddc2f8b0d9a8924eba31f4d920 introduced it. The prototype is in include/linux/device.h and the implementation in lib/devres.c. Thierry
pgpCxLjUEg8yF.pgp
Description: PGP signature