On Thu, 2013-03-07 at 11:39 +0000, Matt Fleming wrote: > On Thu, 2013-03-07 at 18:34 +0800, joeyli wrote: > > The VariableNameSize is not reliable when EFI_SUCCESS is returned > > because UEFI 2.3.1 spec only mention VariableNameSize should updated > > when EFI_BUFFER_TOO_SMALL is returned. And, the 1024 bytes of buffer is > > from old UEFI spec. There doesn't have any size condition of variable > > data or variable name in 2.3.1 spec. > > The spec may only mention what happens in the EFI_BUFFER_TOO_SMALL case, > but for EFI_SUCCESS, any behaviour other than leaving VariableNameSize > alone or updating it with the required size of the buffer is just > completely insane. > > > I modified the patch to grab VariableNameSize when EFI_BUFFER_TOO_SMALL, > > the behavior like what we do in efivarfs_file_read(). > > Thanks, this does seem like the most robust solution.
Also, you're probably going to need to update efivar_update_sysfs_entries() too. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
