pool->worker_idr nor worker->id is not protected by RCU. don't need to free pool->worker_idr by RCU.
Just free it directly. Signed-off-by: Lai Jiangshan <[email protected]> --- kernel/workqueue.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 40f4017..298cefe 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3411,7 +3411,6 @@ static void rcu_free_pool(struct rcu_head *rcu) { struct worker_pool *pool = container_of(rcu, struct worker_pool, rcu); - idr_destroy(&pool->worker_idr); free_workqueue_attrs(pool->attrs); kfree(pool); } @@ -3462,6 +3461,7 @@ static void put_unbound_pool(struct worker_pool *pool) destroy_worker(worker); WARN_ON(pool->nr_workers || pool->nr_idle); + idr_destroy(&pool->worker_idr); spin_unlock_irq(&pool->lock); mutex_unlock(&pool->manager_mutex); mutex_unlock(&pool->manager_arb); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
