On Thu, Apr 4, 2013 at 9:47 AM, Jiri Kosina <[email protected]> wrote: > On Wed, 3 Apr 2013, Huzefa Kankroliwala wrote: > >> With the current i2c hid driver set/get report does not work >> as expected, for e.g sensor hub properties like power state, >> frequency etc is not set properly on the device as a result >> we do not get events. >> The problem is that i2c hid driver in function i2c_hid_request >> sets length equal to default buffer size for which the sensor >> hub does not respond on get/set commands. Use report length >> and calculate it based on report size and id. >> >> Reviewed-by: Mika Westerberg <[email protected]> >> Reviewed-by: Benjamin Tissoires <[email protected]> >> Signed-off-by: Huzefa Kankroliwala <[email protected]> > > This is based on some old version of the driver though. Could you please > rebase it so that it applies on top of for-next branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git > > and resend? (actually rebasing on Linus' current tree would be absolutely > sufficient).
Actually, the patch goes smoothly on your for-next branch on my computer... And there is no point rebasing it on top of Linus' tree as the i2c_hid_request() callback is scheduled for 3.10. Could you double check Jiri? Thanks, Benjamin > > Thanks. > > -- > Jiri Kosina > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
