On Mon, Apr 08, 2013 at 03:21:03PM +0530, Girish KS wrote: > On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown
> > It's also a bit odd that we end up checking cs_gpio and then using line > > in the code, it'd be more idiomatic if cs_gpio were the GPIO number. > In the original driver it was assumed that the cs line is always a gpio pin. > But the current controller that i am working on has no gpio pin for cs > selection. > All the lines to the device are internally connected. There is no > option to select > the cs signal. So cs-gpio property parsing has to skipped for this > controller, that means > cs_gpio cannot be a GPIO number. If it has to be a number then it has > to be < 0 to say > it is not gpio. Any >= 0 number implies it is a valid gpio (in reality > for this controller it is not.) Two options here, one is to just assume nobody will use GPIO 0 and the other is to set the number appopriately during probe so that only probe needs to worry about the issue.
signature.asc
Description: Digital signature
