On Mon, 22 Apr 2013, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > > down the driver. This simple macro should make many of them a little > > > simpler to decipher. The remainder have to stay in place, as they > > > detail slightly more specific settings. > > I would like these to be DMAENGINE_IS_SRC... > > I don't understand, as they're DMA40 specific? > > > and this patch use the defines provided in dmaengine > > I think a subsequent patch doing he following would be more suitable: > > s/STEDMA40_MEM_TO_MEM/DMA_MEM_TO_MEM/ > s/STEDMA40_MEM_TO_PERIPH/DMA_MEM_TO_DEV/ > s/STEDMA40_PERIPH_TO_MEM/DMA_DEV_TO_MEM/ > s/STEDMA40_PERIPH_TO_PERIPH/DMA_DEV_TO_DEV/ > > If you don't mind?
Are you happy to Ack this one too if I follow up with a subsequent patch converting all STEDMA direction defines over to the generic DMA ones? There are also quite a lot in platform data that I'd like to convert too. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
