On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones <[email protected]> wrote: > > > There are lots of lengthy if() statements located sporadically up and > > down the driver. This simple macro should make many of them a little > > simpler to decipher. The remainder have to stay in place, as they > > detail slightly more specific settings. > > > > Cc: Vinod Koul <[email protected]> > > Cc: Dan Williams <[email protected]> > > Cc: Per Forlin <[email protected]> > > Cc: Rabin Vincent <[email protected]> > > Signed-off-by: Lee Jones <[email protected]> > (...) > > > +#define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) > > And when I reas the code and see D40_IS_SRC, what does that > mean? That the channel is a source of .. what exactly? > > The older explicit comparison would be more informative. > > > +#define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ > > + (dir == STEDMA40_MEM_TO_MEM)) ? true : false) > > + > > The comparison to STEDMA40_MEM_TO_MEM is unintelligible, if I see > that macro it has a very unintuitive name, since it is not just > DST but also SRC. > > The latter macro would be named somthing like D40_IS_DST_OR_MEM2MEM > and then it will not simplify the code very much. > > You need to come up with something different here, this is just making the > driver harder to understand. > > I think this patch should be just dropped.
Okay. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
