* Li, Fei <[email protected]> wrote:
> > > Signed-off-by: Liu Chuansheng <[email protected]>
> > > Signed-off-by: Li Fei <[email protected]>
> >
> > The patch looks good, but this is not a valid signoff sequence. If Liu
> > Chuansheng wrote this patch then his From: line should be included. If he
> > acked it, then it should be added as Acked-by.
> >
> Hello Ingo,
> Thanks for your quick feedback.
>
> I add Chuansheng's signature basing on:
> 1> Chuansheng found such hole in code;
> 2> After discussion with Chuansheng, I wrote the patch;
> 3> Chuansheng also acked it.
>
> Do you think it's OK to add Chuansheng's signature in such case?
> Or better suggestion?
Signed-off-by has a specific meaning, it typically means someone authored
or as a maintainer forwarded the code (which did not happen here) - see
the details in Documentation/SubmittingPatches, under this section:
12) Sign your work
If Chuansheng found the bug, there's a Reported-by tag. If Chuansheng
approves of the fix patch then there's Acked-by for that. If he tested it,
then for that there's the Tested-by tag. You can also add several of those
tags.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
