On Tue, 30 Apr 2013, Tim Chen wrote: > > And why is it a pointer? > > A pointer because the default percpu_counter_batch value could change > later when cpus come online after we initialize per cpu counter and > percpu_counter_batch will get computed again in percpu_counter_startup. > Making it a pointer will make it unnecessary to come back and change the > batch sizes if we use static batch value and default batch size.
But you will have to dereference the pointer whenever you want the batch size from the hot path. Looks like it would be better to put the value there directly. You have a list of percpu counters that can be traversed to change the batch size. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

