Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> :
> Removal of unused #define's is a matter of a separate cleanup patch...
Sorry. I won't touch them.
>> +static int rtl8201f_ack_interrupt(struct phy_device *phydev) {
>> + int err;
>> +
>> + err = phy_read(phydev, RTL8201F_ISR);
>
> This could be an initializer and so make the function shorter.
>
Agreed. I just thought it's better to make it similar to the
rtl821x_ack_interrupt. Then, may I make shorter the rtl821x_ack_interrupt as
well as rtl8201f_ack_interrupt?
>
> You haven't run this patch thru scripts/checkpatch.pl -- there should
be a space between *if* and (.
>
Sorry.. what a mistake..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
