Hi Libo, >-----Original Message----- >From: Libo Chen [mailto:[email protected]] >Sent: Thursday, May 09, 2013 4:27 PM >To: Zhang, Sonic; [email protected] >Cc: [email protected]; [email protected]; >linux- >[email protected]; [email protected]; Libo Chen >Subject: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init >successful > >down out_error_no_irq. When platform_get_irq fail, no need to free peripheral > >Signed-off-by: Libo Chen <[email protected]> >--- > drivers/i2c/busses/i2c-bfin-twi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/i2c/busses/i2c-bfin-twi.c >b/drivers/i2c/busses/i2c-bfin-twi.c >index 05080c4..6617645 100644 >--- a/drivers/i2c/busses/i2c-bfin-twi.c >+++ b/drivers/i2c/busses/i2c-bfin-twi.c >@@ -709,9 +709,9 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev) > out_error_add_adapter: > free_irq(iface->irq, iface); > out_error_req_irq: >-out_error_no_irq: > peripheral_free_list((unsigned short *)pdev->dev.platform_data); > out_error_pin_mux: >+out_error_no_irq: > iounmap(iface->regs_base); > out_error_ioremap: > out_error_get_res: >--
Sorry, but you didn't exchange as I suggested. Should be > out_error_req_irq: >-out_error_no_irq: >+out_error_pin_mux: > peripheral_free_list((unsigned short *)pdev->dev.platform_data); >-out_error_pin_mux: >+out_error_no_irq: Regards, Sonic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
