On Thu, 9 May 2013, Libo Chen wrote:
> When usb_create_hcd fail, we should call gxio_usb_host_destroy
>
> Signed-off-by: Libo Chen <libo.c...@huawei.com>
> ---
> drivers/usb/host/ohci-tilegx.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c
> index 1ae7b28..5888fc4 100644
> --- a/drivers/usb/host/ohci-tilegx.c
> +++ b/drivers/usb/host/ohci-tilegx.c
> @@ -112,8 +112,10 @@ static int ohci_hcd_tilegx_drv_probe(struct
> platform_device *pdev)
>
> hcd = usb_create_hcd(&ohci_tilegx_hc_driver, &pdev->dev,
> dev_name(&pdev->dev));
> - if (!hcd)
> - return -ENOMEM;
> + if (!hcd){
> + ret = -ENOMEM;
> + goto err_hcd;
> + }
>
> /*
> * We don't use rsrc_start to map in our registers, but seems like
> @@ -165,6 +167,7 @@ err_have_irq:
> err_no_irq:
> tilegx_stop_ohc();
> usb_put_hcd(hcd);
> +err_hcd:
> gxio_usb_host_destroy(&pdata->usb_ctx);
> return ret;
> }
Acked-by: Alan Stern <st...@rowland.harvard.edu>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
