On Thu, 9 May 2013 15:32:19 +0200, Jiri Olsa wrote: > From: Andi Kleen <[email protected]> > > Add a precise qualifier, like cpu/event=0x3c,precise=1/ > > This is needed so that the kernel can request enabling PEBS > for TSX events. The parser bails out on any sysfs parse errors, > so this is needed in any case to handle any event on the TSX > perf kernel. [SNIP] > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -568,6 +568,12 @@ do { > \ > case PARSE_EVENTS__TERM_TYPE_NAME: > CHECK_TYPE_VAL(STR); > break; > + case PARSE_EVENTS__TERM_TYPE_PRECISE: > + CHECK_TYPE_VAL(NUM); > + if ((unsigned)term->val.num > 2)
Shouldn't it be 3 as we technically allow the 'ppp' modifier? Although there's no cpu suppports precise=3 currently, things can be changed. :) Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
