On 16.05.13 17:54:59, Josh Boyer wrote: > On Thu, May 16, 2013 at 10:55:58PM +0200, Robert Richter wrote: > > On 16.05.13 20:10:18, Peter Zijlstra wrote: > > > I would make it a FW_BUG as well. But yeah, I suppose that is a better > > > option > > > than the WARN_ON. Unless Robert had a different reason... > > > > iirc the reason was the different msr range that is switched on fam15h > > with a different counter to counter msr offset of 2 instead of 1. The > > code relies on the assumption that the msrs exist on that cpu. Thus > > the warning if not. Also note that code may have changed in 3.10 in > > that area. > > Again, what is someone supposed to do with a backtrace from the WARN? > As far as I can see, a user can't really do anything other than report > it and then there's nothing to fix. > > The code might have moved in 3.10, but the WARN is still there. > > Would you like me to send a patch to get it reduced to pr_err?
I wrote the code with the assumption of a certain system layout which was the check for. Now, in a vm this assumption is no longer valid. Will change the code in a way this is handled properly. -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
