On 24.06.13 21:24:04, Borislav Petkov wrote: > On Mon, Jun 24, 2013 at 11:28:07AM +0200, Peter Zijlstra wrote: > > I find this patch incomplete for its asymmetric; there a dec, but not an > > implied inc. > > There's one in perf_mmap_open. > > Basically the idea was to pull up the ->mmap_count decrement (haha, > sounds like excrement :-)) and not deallocate the ring buffers for a > persistent event.
The asymmetry comes from rb_alloc() in add_persistent_event_on_cpu() which is usually implemented in the mmap functions. We might better improve functions to attach/detach events and buffers for more symmetric code. -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
