Wedson Almeida Filho <[email protected]> writes: > There is no functional change, but this change eliminates a subtraction that > the compiler doesn't optimize out (as of gcc 4.7.3). > > Signed-off-by: Wedson Almeida Filho <[email protected]> > --- > lib/bsearch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/bsearch.c b/lib/bsearch.c > index e33c179..3264146 100644 > --- a/lib/bsearch.c > +++ b/lib/bsearch.c > @@ -37,7 +37,7 @@ void *bsearch(const void *key, const void *base, size_t > num, size_t size, > int result; > > while (start < end) { > - size_t mid = start + (end - start) / 2; > + size_t mid = (start + end) / 2; > > result = cmp(key, base + mid * size); > if (result < 0) > -- > 1.7.9.5
Please add a comment about overflow instead? Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
