Commit-ID:  ad3d6f508738323c0e843c4dbdd421c1aeb59cd8
Gitweb:     http://git.kernel.org/tip/ad3d6f508738323c0e843c4dbdd421c1aeb59cd8
Author:     Jiri Olsa <jo...@redhat.com>
AuthorDate: Mon, 17 Jun 2013 18:02:43 +0200
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Fri, 12 Jul 2013 13:46:05 -0300

perf tools: Do not elide parent symbol column

I found the parent symbol column data interesting even
if there's another sorting enabled. Switching it on.

Previous behaviour:
  $ perf report -i perf.data.delete -p perf_session__delete -x

  +   3.60%  perf  perf               [.] __rb_change_child
  +   1.89%  perf  perf               [.] rb_erase
  +   1.89%  perf  perf               [.] rb_erase
  +   1.83%  perf  perf               [.] free@plt

Current behaviour:
  $ perf report -i perf.data.delete -p perf_session__delete -x

  +   3.60%  perf  perf               [.] __rb_change_child        
perf_session__delete
  +   1.89%  perf  perf               [.] rb_erase                 
perf_session__delete_dead_threads
  +   1.89%  perf  perf               [.] rb_erase                 
perf_session__delete_threads
  +   1.83%  perf  perf               [.] free@plt                 
perf_session__delete

Signed-off-by: Jiri Olsa <jo...@redhat.com>
Cc: Andi Kleen <a...@linux.intel.com>
Cc: Corey Ashford <cjash...@linux.vnet.ibm.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Frederic Weisbecker <fweis...@gmail.com>
Cc: Ingo Molnar <mi...@elte.hu>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Paul Mackerras <pau...@samba.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Link: http://lkml.kernel.org/n/tip-r79fn89bhqz16ixa5zmyf...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-report.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 3662047..6ab49da 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -931,14 +931,6 @@ repeat:
        if (parent_pattern != default_parent_pattern) {
                if (sort_dimension__add("parent") < 0)
                        goto error;
-
-               /*
-                * Only show the parent fields if we explicitly
-                * sort that way. If we only use parent machinery
-                * for filtering, we don't want it.
-                */
-               if (!strstr(sort_order, "parent"))
-                       sort_parent.elide = 1;
        }
 
        if (argc) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to