On 07/23/2013 03:39 PM, Ingo Molnar wrote:

* Tang Chen<[email protected]>  wrote:

We wanted to check if the acpi id is out of range. It should be:
        if (id>= (MAX_LOCAL_APIC)).

Does this have any practical impact, or can it wait until v3.12?

I haven't tested out any impact now, just found it when reading the code.
We can wait until v3.12.


Signed-off-by: Tang Chen<[email protected]>
---
  arch/x86/kernel/acpi/boot.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index d81a972..2a15ae7 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 
enabled)
  {
        unsigned int ver = 0;

-       if (id>= (MAX_LOCAL_APIC-1)) {
+       if (id>= (MAX_LOCAL_APIC)) {

The parentheses are now superfluous.

Oh, yes. I'll send a new version without the parentheses.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to