2013/7/5 Vinod Koul <[email protected]>: > On Tue, Jun 18, 2013 at 02:21:58PM +0800, Xiang Wang wrote: >> From: Xiang Wang <[email protected]> >> >> pdev->phy is of type "struct mmp_pdma_phy *". But when >> allocating memory for it, "struct mmp_pdma_chan" is used >> by mistake. >> >> Signed-off-by: Xiang Wang <[email protected]> >> --- >> drivers/dma/mmp_pdma.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c >> index c26699f..18ac57f 100644 >> --- a/drivers/dma/mmp_pdma.c >> +++ b/drivers/dma/mmp_pdma.c >> @@ -801,7 +801,7 @@ static int mmp_pdma_probe(struct platform_device *op) >> } >> >> pdev->phy = devm_kzalloc(pdev->dev, >> - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); >> + dma_channels * sizeof(*pdev->phy), GFP_KERNEL); > While at it, can you make the flag GFP_NOWAIT. that is the recommendation for > dmac drivers > > -- > ~Vinod
Hi, Vinod Would you please explain a little more about why we should use GFP_NOWAIT here? This memory is not dedicated for DMA controller. Do we have special reasons to use GFP_NOWAIT? Thanks! -- Regards, Xiang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
