On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote: > > Here's another example. get_lppaca() will only build on book3s -- and > > yet we get requests for e500 code to use this file. > > Indeed, Besides there is already accessors afaik for lppaca that compile > to nothing on E (and if not they would be trivial to add).
I don't see such an accessor, but if there were, what would happen when the caller goes on to dereference that nothing? There is an accessor for shared_proc specifically (in the spinlock code) -- not that it would be much help on booke to just compile away that check and always select one of the pseries state tables over the other. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
