On Fri, Aug 02, 2013 at 02:03:47PM +0200, Piotr Sarna wrote: > Commit 5688978 ("ext4: improve handling of conflicting mount options") > introduced incorrect messages shown while choosing wrong mount options. > > Firstly, both cases of incorrect mount options, "data=journal,delalloc" > and "data=journal,dioread_nolock" result in the same error message. > > Secondly, the problem above isn't solved for remount option: the mismatched > parameter is simply ignored. Moreover, ext4_msg states that remount > with options "data=journal,delalloc" succeeded, which is not true. > > To fix it up, I added a simple check after parse_options() call to ensure > that data=journal and delalloc/dioread_nolock parameters are not present > at the same time. > > Signed-off-by: Piotr Sarna <p.sa...@partner.samsung.com> > Acked-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/