On Tue, Aug 13, 2013 at 08:25:18PM +0200, Andi Kleen wrote:
> > Make it a bigger mess: :-)
>
> Ok. Only the second union is enough, it only needs the flags,
> not the cycles.
>
> >
> > struct hsw_tsx_abort_info {
> > union {
> > u64 value;
> > struct {
> > u32 cycles_last_tx;
> > union {
> > };
> >
> > Also, I think your patch is 'broken' in that it dumps the reserved bits
> > out to userspace and this brand spanking new SDM doesn't say they're 0.
>
> Will fix.
>
> > __intel_pmu_pebs_event() isn't getting any prettier with all those
> > pebs_format tests; but I'm not seeing anything to really fix that.
>
> Ok. Are you merging your patch with these changes (fll, union)
> or should I send a new one?
Please send a new one that is actually tested. Mine didn't see a
compiler up close nor do I have the hardware to verify it actually does
something sane.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
