On Mon, 2013-08-26 at 16:31 -0400, David Miller wrote: > From: Enrico Mioso <[email protected]> [] > > + int ret = 0; > > + struct usbnet *usbnet_dev = usb_get_intfdata(intf); > > + struct huawei_cdc_ncm_state *drvstate = (void *)&usbnet_dev->data; > > + struct cdc_ncm_ctx *ctx = drvstate->ctx; > > + bool callsub = (intf == ctx->control && drvstate->subdriver && > > drvstate->subdriver->resume); /* should we call subdriver's resume? ? */ > > Likewise, and order local function variable declarations by line > length, longest to shortest.
I think the premise of local variable declaration by line length is flawed. It can't work when local variables are dependent on initialization order as above. int ret; could be moved down below callsub if really desired though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
