David Ahern <dsah...@gmail.com> writes:
> On 10/11/13 9:11 AM, David Ahern wrote:
>> It would be nice to fix the callchain arg handler to not attempt to
>> process the next argument if it is not fp or dwarf.
>
> Specifically, something like this which maintains syntax and default
> fp option:
Yes please! This happens to me all the time too
(usually I train myself to use -g --, but i still sometimes forget)
It still wouldn't handle -ga, but naked -g seems to be the common case.
-Andi
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 92ca541..23d782c 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -766,8 +766,8 @@ int record_parse_callchain_opt(const struct option *opt,
> opts->stack_dump_size);
> #endif /* HAVE_LIBUNWIND_SUPPORT */
> } else {
> - pr_err("callchain: Unknown -g option "
> - "value: %s\n", arg);
> + opts->call_graph = CALLCHAIN_FP;
> + ret = 0;
> break;
> }
>
>
--
a...@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
