Ning Qu wrote:
> you mean something like this? If so, then fixed.
> 
>                if (must_use_thp) {
>                         page = shmem_alloc_hugepage(gfp, info, index);
>                         if (page) {
>                                 count_vm_event(THP_WRITE_ALLOC);
>                         } else
>                                 count_vm_event(THP_WRITE_ALLOC_FAILED);
>                 } else {
>                         page = shmem_alloc_page(gfp, info, index);
>                 }
> 
>                 if (!page) {
>                         error = -ENOMEM;
>                         goto unacct;
>                 }
>                 nr = hpagecache_nr_pages(page);

Yeah.

count_vm_event() part still looks ugly, but I have similar in my code.
I'll think more how to rework in to make it better.

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to