On 10/29/2013 04:34 PM, Max Filippov wrote: > On Tue, Oct 29, 2013 at 11:57 AM, Chen Gang <[email protected]> wrote: >> On 10/28/2013 07:18 PM, Max Filippov wrote: >>> Hi Chen, >>> >>> On Mon, Oct 28, 2013 at 2:30 PM, Chen Gang <[email protected]> wrote: >>>>> For some toolchains, they use another character as newline in a macro >>>>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >>>>> macro) instead of ';' for it. >>>>> Since "linux/export.h" are mainly used for exporting work, then our fix >>>>> more likely belongs to "linux/linkage.h", and we need add the related >>>>> checking in "linkage.h". >>>>> >>>>> Also need notice 80 columns wrap, and '\t' for each line. >>>>> >>>>> >>>>> Signed-off-by: Chen Gang <[email protected]> >>>>> --- >>>>> arch/arc/include/asm/linkage.h | 2 + >>>>> include/asm-generic/vmlinux.lds.h | 350 >>>>> +++++++++++++++++++------------------ >>> Actually vmlinux.lds.h is not an assembly code, but rather a linker script, >>> later preprocessed by cpp. >>> >> >> Consult: do xtensa also has its own ASM_NL? > > It works well with common semicolon. >
Thank you for your confirmation. After scan the "arch/" sub-directory, except arc, the cris, c6x, frv, and parisc are also use ';' as comments, I guess they will welcome this patch. And some of another architectures may use '#', '|', '!', '@' or "//" as line comment mark. It seems most of them support ';' as newline in the macro, but it is also necessary to give a check. If this patch is applied, I will/should sync all the related architectures to let ASM_NL consistency. :-) Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
