>> + /* >> + * DWC3 requires buffer size to be aligned to maxpacketsize >> + * of an out endpoint. >> + * FIXME: a more generic solution might be necessary. >> + */ > > see, gadget drivers shouldn't have to know about DWC3 at all. They need > to know that current UDC has a quirk where EP OUT transactions need to > be aligned to wMaxPacketSize, so what I was expecting to see here was: > > if (test_bit(USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE, > &gadget->qirks) && > !IS_ALIGNED(len, ep->ep->desc->wMaxPacketSize)) > len = align_length(orig_len, wMaxPacketSize);
That makes sense. I'll send a new version. Thanks, David Cohen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
