> -----Original Message----- > From: Chanwoo Choi [mailto:[email protected]] > Sent: Monday, November 04, 2013 10:37 AM > To: Wang, Xiaoming > Cc: [email protected]; [email protected]; Liu, > Chuansheng; Zhang, Dongxing > Subject: Re: [PATCH] [extcon]:remove freed groups caused the panic or warning > in unregister flow
> As you comment, my opinion has memory leak problem. My mistake. > But, I prefer to call 'device_unregister' at the end of > extcon_dev_unregister(). > To resolve kernel panic, I think we could use 'devm_kzalloc' instead of > kzalloc/kfree. > What is your opinion about my approach? > That sounds good. But in function extcon_dev_register(), the device attributes are allocated before device_register(), and before device_register(), the function devm_kzalloc() can not be used.
