On 11/04/2013 12:47 PM, Liu, Chuansheng wrote: > > >> -----Original Message----- >> From: Chanwoo Choi [mailto:[email protected]] >> Sent: Monday, November 04, 2013 10:37 AM >> To: Wang, Xiaoming >> Cc: [email protected]; [email protected]; Liu, >> Chuansheng; Zhang, Dongxing >> Subject: Re: [PATCH] [extcon]:remove freed groups caused the panic or warning >> in unregister flow > > >> As you comment, my opinion has memory leak problem. My mistake. >> But, I prefer to call 'device_unregister' at the end of >> extcon_dev_unregister(). >> To resolve kernel panic, I think we could use 'devm_kzalloc' instead of >> kzalloc/kfree. >> What is your opinion about my approach? >> > That sounds good. > But in function extcon_dev_register(), the device attributes are allocated > before device_register(), > and before device_register(), the function devm_kzalloc() can not be used. >
We could use 'edev->dev->parent' pointer for devm_kzalloc() but it is ambiguous method. OK, applied this patch. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
