* Felipe Contreras <[email protected]> wrote:
> On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar <[email protected]> wrote:
> >
> > * Felipe Contreras <[email protected]> wrote:
> >
> >> Signed-off-by: Felipe Contreras <[email protected]>
> >
> > The changelog is missing and the title is not self-explanatory.
>
> Either the local IRQs should be enabled for both the restart and halt
> blinks, or it shouldn't be enabled for either. Why enable them for
> halt, but not restart?
>
> I think enabling them for restart too makes sense.
Such arguments belong into the changelog, with a description of what was
done before and what is done after - please use the customary (verbose)
changelog style we use in the kernel.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
