On Sat, Nov 16, 2013 at 04:18:55PM -0600, Ashley Lai wrote: > Nice clean up!!! The code looks much more clean after removing the > duplicated code in all drivers. Thanks.
> > +++ b/drivers/char/tpm/tpm-dev.c > > + * Copyright (C) 2013 Obsidian Reearch Corp > > Typo Research? Yes, thanks :) > > + * Jason Gunthorpe <[email protected]> > > + * > > > + > > +int tpm_dev_add_device(struct tpm_chip *chip) > > +{ > > > + rc = misc_register(&chip->vendor.miscdev); > > + if (rc) { > > + chip->vendor.miscdev.name = NULL; > > + dev_warn(chip->dev, > > Any reason why we use dev_warn here instead of dev_err? Indeed, it was dev_err before I moved it. Hmm, it has been so long.. I think an earlier draft had tpm_dev_add_device return void (like in other subsystems), so warn made more sense. However I eventually changed it to propogate errors, and didn't catch the flip. Lets put it back. Thanks! Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
