On Mon, 9 Dec 2013 15:30:09 -0300
Arnaldo Carvalho de Melo <[email protected]> wrote:
> > + error = malloc(MAX_ERR_STR_SIZE);
> > + if (error == NULL) {
> > + /* no memory */
> > + *error_str = "failed to allocate memory";
> > + return;
>
> Can *error_str point to either malloc'ed or constant strings? Who
> releases the allocated memory?
>
Good question. Perhaps we should have a flag that states if the string
is allocated or not. Or better yet, since the only reason it would be
pointing to a static string is if the string for error_str itself
failed to allocate. Then we could use a string within pevent for it:
static char *pevent_failed_error_alloc = "failed to allocate memory";
Then in the freeing of error str:
void pevent_free_error_str(error_str)
{
if (error_str != pevent_failed_error_alloc)
free(error_str);
}
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
