On Thu, Dec 26, 2013 at 04:47:50PM +0400, Sergei Shtylyov wrote: > Hello. > > On 26-12-2013 15:41, Ding Tianhong wrote: > > >Use possibly more efficient ether_addr_equal_unaligned > >instead of memcmp. > > >Cc: Larry Finger <[email protected]> > >Cc: Chaoming Li <[email protected]> > >Cc: John W. Linville <[email protected]> > >Cc: [email protected] > >Cc: [email protected] > >Cc: [email protected] > >Signed-off-by: Weilong Chen <[email protected]> > >Signed-off-by: Ding Tianhong <[email protected]> > >--- > > drivers/net/wireless/rtlwifi/cam.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >diff --git a/drivers/net/wireless/rtlwifi/cam.c > >b/drivers/net/wireless/rtlwifi/cam.c > >index 0e510f7..0276153 100644 > >--- a/drivers/net/wireless/rtlwifi/cam.c > >+++ b/drivers/net/wireless/rtlwifi/cam.c > [...] > >@@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 > >*sta_addr) > > addr = rtlpriv->sec.hwsec_cam_sta_addr[i]; > > bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i; > > if (((bitmap & BIT(0)) == BIT(0)) && > >- (memcmp(addr, sta_addr, ETH_ALEN) == 0)) { > >+ (ether_addr_equal_unaligned(addr, sta_addr))) { > > It's pointless to enclose function call in parens, again.
I'll correct that issue when merging the patch. -- John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
