On Thu 16-01-14 14:49:25, David Rientjes wrote: > On Thu, 16 Jan 2014, Michal Hocko wrote: > > > > When two threads have the same badness score, it's preferable to kill the > > > thread group leader so that the actual process name is printed to the > > > kernel log rather than the thread group name which may be shared amongst > > > several processes. > > > > I am not sure I understand this. Is this about ->comm? If yes then why > > couldn't the group leader do PR_SET_NAME? > > > > Both comm and pid, we only display thread group leaders in the tasklist > dump of eligible processes, we want the killed message to specify from > which process.
OK, that makes sense now. I didn't think about dump_tasks and consistency in the output. > You're suggesting a thread group leader do PR_SET_NAME of all its threads > for readable oom killer output? Lol. No, I am not suggesting anything. I was just asking why is group leader different in this regards becasue changelog didn't tell it and I didn't put it together with dump_tasks. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
