On Thu, 2014-02-13 at 17:51 +0530, Yadwinder Singh Brar wrote: > Hi, > > On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski > <[email protected]> wrote: > > Add __initconst to 'regulator_desc' array with supported regulators. > > During probe choose how many and which regulators will be supported > > according to device ID. Then copy the 'regulator_desc' array to > > allocated memory so the regulator core can use it. > > > > Additionally allocate array of of_regulator_match() dynamically (based > > on number of regulators) instead of allocation on the stack. > > > > This is needed for supporting different devices in s2mps11 > > driver and actually prepares the regulator driver for supporting the > > S2MPS14 device. > > > > Code for supporting the S2MPS14 device will add its own array of > > 'regulator_desc' (also marked as __initconst). This way memory footprint > > of the driver will be reduced (approximately 'regulators_desc' array for > > S2MPS11 occupies 5 kB on 32-bit ARM, for S2MPS14 will occupy 3 kB). > > > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > Signed-off-by: Chanwoo Choi <[email protected]> > > Cc: Mark Brown <[email protected]> > > Cc: Liam Girdwood <[email protected]> > > Cc: Yadwinder Singh Brar <[email protected]> > > --- > > Just observed one trivial thing that in this patch, spacing is not > provided before and after multiplication binary operator ( _ * _ ), > which is recommended by linux spacing convention. > > Other than that it looks fine to me, pls feel free to add > > Reviewed-by: Yadwinder Singh Brar <[email protected]> >
Thanks for review. I'll send a patch with proper spacing around '*'. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
